refactor logger to simple logger by kfirstri · Pull Request #425 · base44/cli

kfirstri · 2026-03-17T14:44:13Z

Note

Description

This PR extracts a @base44-cli/logger package that provides a Logger interface with two implementations: ClackLogger for interactive TTY sessions (delegates to @clack/prompts) and SimpleLogger for non-interactive/CI environments (writes plain text to stderr). The logger is injected into CLIContext and passed as the first argument to all action functions via Base44Command, replacing direct @clack/prompts log imports throughout commands.

Related Issue

None

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (no functional changes)
Other (please describe):

Changes Made

Created packages/logger workspace package (@base44-cli/logger) with a Logger interface, ClackLogger (interactive), and SimpleLogger (CI/non-interactive)
Added log: Logger to CLIContext — instantiated as ClackLogger or SimpleLogger based on TTY detection at startup in runCLI()
Updated Base44Command.action() to inject CLIContext as the first argument to every action function, removing the need for commands to access it via the Commander command instance
Removed the isNonInteractive getter from Base44Command (now accessed via destructured context)
Updated ensureAuth and ensureAppConfig middleware to accept CLIContext instead of just ErrorReporter
Migrated all command files to destructure { log } / { log, isNonInteractive } from the injected context instead of importing log from @clack/prompts directly
Updated docs/commands.md to reflect the new context-injection pattern and Logger usage
Re-exported Logger, ClackLogger, and SimpleLogger from @/cli/utils/index.js

Testing

I have tested these changes locally
I have added/updated tests as needed
All tests pass (npm test)

Checklist

My code follows the project's style guidelines
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (if applicable)
My changes generate no new warnings
I have updated docs/ (AGENTS.md) if I made architectural changes

Additional Notes

The Logger interface maps 1:1 to @clack/prompts log methods (info, success, warn, error, step, message), so migrating commands is mechanical. The SimpleLogger writes all output to stderr to keep stdout clean for machine-readable output in CI pipelines.

_{🤖 Generated by Claude | 2026-03-23 00:00 UTC}

github-actions · 2026-03-17T14:44:51Z

🚀 Package Preview Available!

Install this PR's preview build with npm:

npm i @base44-preview/cli@0.0.47-pr.425.4dfac63

Prefer not to change any import paths? Install using npm alias so your code still imports base44:

npm i "base44@npm:@base44-preview/cli@0.0.47-pr.425.4dfac63"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "base44": "npm:@base44-preview/cli@0.0.47-pr.425.4dfac63"
  }
}

📦 Preview Package: @base44-preview/cli@0.0.47-pr.425.4dfac63
🔗 View this commit on GitHub

_{Preview published to npm registry — try new features instantly!}

artemdemo · 2026-03-19T13:57:43Z

packages/logger/src/ClackLogger.ts

Maybe logger should be a separate package?
wdyt?

Love this idea, what do you think about the name @base44-cli/logger? maybe just @base44/logger?

artemdemo · 2026-03-22T08:48:37Z

packages/logger/package.json

+  "version": "0.0.1",
+  "description": "Logger interface and implementations for Base44 CLI",
+  "type": "module",
+  "main": "./src/index.ts",


Why do you need main?

so our tsconfig was set to "moduleResolution": "node" which didn't support "exports", only "main".. working on this

artemdemo · 2026-03-22T08:51:54Z

knip.json

      "ignoreDependencies": ["@types/deno"]
+    },
+    "packages/logger": {
+      "project": ["src/**/*.ts"]


Here you don't need entry?
Why it's needed in packages/cli?

looked it up, knip recognize the entry by the exports, and since the cli package uses the bin/ folder we need to specify it.. but i removed it for logger package.

artemdemo · 2026-03-22T08:52:33Z

knip.json

@@ -7,6 +7,9 @@
      "project": ["src/**/*.ts", "tests/**/*.ts"],
      "ignore": ["dist/**", "tests/fixtures/**"],


Do we really need "dist/**" in ignore?

good catch, removed

# Conflicts: # bun.lock # packages/cli/src/cli/utils/command/Base44Command.ts

kfirstri · 2026-03-23T16:57:18Z

tsconfig.base.json

    "module": "ES2022",
    "lib": ["ES2022"],
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",


@artemdemo what do you think about this?
this makes it so packag.json will support "exports" and not just "main"
in wix-cli we use "node16", but it seems it raises other issues.. maybe i can first bump to node16 in another branch and then fix this

refactor logger to simple logger

8eb194c

kfirstri added 4 commits March 17, 2026 19:07

refactor all the action function to recieve a logger

da7493d

fix knip issues

3681e63

use log and not logger

e201f1b

use log and not logger

a58c4ac

kfirstri added this to CLI Development Mar 18, 2026

github-project-automation bot moved this to Backlog in CLI Development Mar 18, 2026

kfirstri moved this from Backlog to In progress in CLI Development Mar 18, 2026

kfirstri added 2 commits March 19, 2026 15:19

Merge remote-tracking branch 'origin/main' into refactor-logger

79d4ef5

update logger

97403bd

kfirstri force-pushed the refactor-logger branch from 2f0e68a to 97403bd Compare March 19, 2026 13:33

kfirstri requested a review from artemdemo March 19, 2026 13:52

artemdemo reviewed Mar 19, 2026

View reviewed changes

Merge branch 'main' into refactor-logger

2ddd779

kfirstri force-pushed the refactor-logger branch from 1bd5790 to 2ddd779 Compare March 19, 2026 14:29

refactor logger to be a package

be45f97

artemdemo reviewed Mar 22, 2026

View reviewed changes

kfirstri added 2 commits March 23, 2026 16:42

Merge branch 'main' into refactor-logger

0ff404e

# Conflicts: # bun.lock # packages/cli/src/cli/utils/command/Base44Command.ts

handle comments from review

2237744

kfirstri requested a review from artemdemo March 23, 2026 16:56

kfirstri commented Mar 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor logger to simple logger#425

refactor logger to simple logger#425
kfirstri wants to merge 11 commits intomainfrom
refactor-logger

kfirstri commented Mar 17, 2026 •

edited by claude bot

Loading

Uh oh!

github-actions bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

artemdemo Mar 19, 2026

Uh oh!

kfirstri Mar 19, 2026

Uh oh!

artemdemo Mar 22, 2026

Uh oh!

kfirstri Mar 23, 2026

Uh oh!

artemdemo Mar 22, 2026

Uh oh!

kfirstri Mar 23, 2026

Uh oh!

artemdemo Mar 22, 2026

Uh oh!

kfirstri Mar 23, 2026

Uh oh!

kfirstri Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -7,6 +7,9 @@
		"project": ["src/*/.ts", "tests/*/.ts"],
		"ignore": ["dist/", "tests/fixtures/"],

Conversation

kfirstri commented Mar 17, 2026 • edited by claude bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Changes Made

Testing

Checklist

Additional Notes

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Package Preview Available!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kfirstri commented Mar 17, 2026 •

edited by claude bot

Loading

github-actions bot commented Mar 17, 2026 •

edited

Loading